Add a lock for the Poetry tool.#16117
Merged
jsirois merged 2 commits intopantsbuild:mainfrom Jul 10, 2022
Merged
Conversation
[ci skip-rust] [ci skip-build-wheels]
This was referenced Jul 10, 2022
jsirois
commented
Jul 10, 2022
| DefaultTool.python(Yapf, backend="pants.backend.python.lint.yapf"), | ||
| DefaultTool.python(Lambdex, backend="pants.backend.awslambda.python"), | ||
| DefaultTool.python(MyPy, source_plugins=True), | ||
| DefaultTool.python(PoetrySubsystem), |
Contributor
Author
There was a problem hiding this comment.
This was the only real change (addition), the rest was alphabetizing the two groups (Python tools and JVM tools) individually.
[ci skip-rust] [ci skip-build-wheels]
benjyw
approved these changes
Jul 10, 2022
jsirois
commented
Jul 10, 2022
| async def setup_poetry_lockfile( | ||
| _: PoetryLockfileSentinel, poetry_subsystem: PoetrySubsystem, python_setup: PythonSetup | ||
| ) -> GeneratePythonLockfile: | ||
| # No matter what venv (Python) Poetry lives in, it can still create locks for projects with |
Contributor
Author
There was a problem hiding this comment.
For the record, I went through the exercise of testing this with poetry 1.1.14 installed both in a 2.7 venv and a 3.11 venv creating project locks for the opposite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ci skip-rust]
[ci skip-build-wheels]