Skip to content
This repository was archived by the owner on Aug 2, 2023. It is now read-only.

Update grpc-sys/grpc submodule.#1

Merged
jsirois merged 1 commit intopantsbuild:pants-usefrom
jsirois:grpc/update-with-compile-fix
Oct 19, 2019
Merged

Update grpc-sys/grpc submodule.#1
jsirois merged 1 commit intopantsbuild:pants-usefrom
jsirois:grpc/update-with-compile-fix

Conversation

@jsirois
Copy link
Copy Markdown

@jsirois jsirois commented Oct 19, 2019

This picks up a compilation fix for modern gcc and clang from:
https://github.com/pantsbuild/grpc rs-release @ 045edfdd29

Work towards fixing pantsbuild/pants#8472

This picks up a compilation fix for modern gcc and clang from:
https://github.com/pantsbuild/grpc rs-release @ 045edfdd29

Work towards fixing pantsbuild/pants#8472
@jsirois jsirois requested a review from illicitonion October 19, 2019 23:43
@jsirois
Copy link
Copy Markdown
Author

jsirois commented Oct 19, 2019

@illicitonion this is again a TBR FYI and the update to point to pantsbuild/grpc#1.

@jsirois jsirois merged commit b582ef3 into pantsbuild:pants-use Oct 19, 2019
jsirois added a commit to jsirois/pants that referenced this pull request Oct 20, 2019
This picks up a compilation fix under modern gcc/clang for the
grpc-sys/grpc submodule.

See:
  pantsbuild/grpc#1
  pantsbuild/grpc-rs#1

Fixes pantsbuild#8472
Copy link
Copy Markdown

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stuhood pushed a commit to pantsbuild/pants that referenced this pull request Oct 22, 2019
This picks up a compilation fix under modern gcc/clang for the
grpc-sys/grpc submodule.

See:
  pantsbuild/grpc#1
  pantsbuild/grpc-rs#1

Fixes #8472
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants