[major] Refactor WP install scripts to use WP-CLI #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we can debug this in the mu-plugin
pwtyler
reviewed
Feb 8, 2024
Member
pwtyler
left a comment
pwtyler
left a comment
There was a problem hiding this comment.
these were written before our discussion earlier but posting all the same
replacing with our own using wpcli
for local install
Co-authored-by: Phil Tyler <[email protected]>
Co-authored-by: Phil Tyler <[email protected]>
so we don't run into global clashes
rather than overwriting it
not sure where things are failing exactly
it's only needed for non-nightly runs
pwtyler
reviewed
Feb 13, 2024
Co-authored-by: Phil Tyler <[email protected]>
…-helpers into add-more-helpers
we don't need to pass args into it because we don't pass args into the script
pwtyler
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the scripts to no longer use the community-contributed
install-wp-tests.shscript.Functions have been broken out into a
helpers.shfile that is sourced where needed.Tests have been updated and additional tests that run through the actual scripts have been added to this repository. This is a major change since there are fundamental improvements made to how the scripts even work.
Additionally, improvements have been made to the internal tests as a whole, pulling complex scripting out of the
test.ymlfile and into their own scripts in.github/workflows/bin.Pulled out of pantheon-systems/pantheon-mu-plugin#29 so the scripts can be centralized and updated in one place rather than using copy/pasta.
Successful run using this package: https://github.com/pantheon-systems/pantheon-mu-plugin/actions/runs/7836581235/job/21422397789