[BUGS-10105] Fix SimpleSAMLphp 2.x Auto-Detection #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwtyler
reviewed
Jan 5, 2026
inc/class-wp-saml-auth-cli.php
Outdated
Comment on lines
94
to
96
| // SimpleSAMLphp autoloader path is auto-detected. Only set if using a non-standard location. | ||
| // 'simplesamlphp_autoload' => __DIR__ . '/simplesamlphp/vendor/autoload.php', // v2.x. | ||
| // 'simplesamlphp_autoload' => __DIR__ . '/simplesamlphp/lib/_autoload.php', // v1.x. |
Member
There was a problem hiding this comment.
Suggested change
| // SimpleSAMLphp autoloader path is auto-detected. Only set if using a non-standard location. | |
| // 'simplesamlphp_autoload' => __DIR__ . '/simplesamlphp/vendor/autoload.php', // v2.x. | |
| // 'simplesamlphp_autoload' => __DIR__ . '/simplesamlphp/lib/_autoload.php', // v1.x. |
This is called out in the docs to add if needed, no need to have commented out, I think. (although perhaps add a 'simplesamlphp_autoload' => '...' suggestion line there)
Contributor
Author
There was a problem hiding this comment.
Agree, it's for a specific scenario that users would have to check the documentation for. Code updated.
|
Hi from your friendly robot! 🤖 I fixed PHPCS issues with |
pwtyler
approved these changes
Jan 7, 2026
AnaisPantheor
added a commit
that referenced
this pull request
Jan 8, 2026
* Adds vendor path for composer ssp install * Update the cli command for config path * Update documentation for SSP composer install 1.x and 2.x versions --------- Co-authored-by: Pantheon Robot <[email protected]>
AnaisPantheor
added a commit
that referenced
this pull request
Jan 8, 2026
* Adds vendor path for composer ssp install * Update the cli command for config path * Update documentation for SSP composer install 1.x and 2.x versions --------- Co-authored-by: Pantheon Robot <[email protected]>
AnaisPantheor
added a commit
that referenced
this pull request
Jan 9, 2026
* Adds vendor path for composer ssp install * Update the cli command for config path * Update documentation for SSP composer install 1.x and 2.x versions --------- Co-authored-by: Pantheon Robot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customers using SimpleSAMLphp 2.x (especially via Composer) experienced "Invalid provider specified for SAML authentication" errors after upgrading from v2.1.4 to v2.2.0. The plugin's autoloader search only checked for SimpleSAMLphp v1.x paths (lib/_autoload.php) in default locations, missing v2.x installations that use vendor/autoload.php.
inc/class-wp-saml-auth.php
Added Composer vendor path to default search paths (line 541):
- Added ABSPATH . 'vendor/simplesamlphp/simplesamlphp' to the default search array
- Enables automatic detection of Composer installations without manual configuration
Enhanced autoloader detection to support both v1.x and v2.x (lines 548-558):
- For each base path, now checks vendor/autoload.php (v2.x) first
- Falls back to lib/_autoload.php (v1.x) if v2.x autoloader not found
- Maintains backward compatibility with existing v1.x installations
inc/class-wp-saml-auth-cli.php
Updated WP-CLI scaffold defaults (lines 94-96):
The scaffold_config_function() method generates example configuration code when users run wp saml-auth scaffold-config.
The old code was outdated, implied manual configuration, and only showed the SimpleSAMLphp v1.x path (lib/_autoload.php), not the v2.x support.
Now it indicates that auto-detection works and that you only need to set this for non-standard locations.