-
Notifications
You must be signed in to change notification settings - Fork 46
[SITE-5067] Fix SimpleSAMLphp warnings showing for OneLogin/internal connector users #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@jazzsequence any chance you could review this? |
Member
|
I'd like to see behat -> GHA move decoupled from the bug fix in this PR. |
pwtyler
reviewed
Dec 15, 2025
pwtyler
reviewed
Dec 15, 2025
e126d5e to
d2c743a
Compare
Merged
|
Hi from your friendly robot! 🤖 I fixed PHPCS issues with |
Contributor
Author
The ticket has been split into two: the Behat tests: #447 and the optimization of the warning message (this ticket). |
8cdf0b3 to
9638421
Compare
namespacebrian
approved these changes
Dec 18, 2025
pwtyler
reviewed
Dec 18, 2025
pwtyler
approved these changes
Dec 19, 2025
pwtyler
reviewed
Dec 19, 2025
AnaisPantheor
added a commit
that referenced
this pull request
Jan 8, 2026
…connector users (#445) * update readme and changelog * refactor scenarios * Add more early returns --------- Co-authored-by: Pantheon Robot <[email protected]> Co-authored-by: Phil Tyler <[email protected]>
AnaisPantheor
added a commit
that referenced
this pull request
Jan 8, 2026
…connector users (#445) * update readme and changelog * refactor scenarios * Add more early returns --------- Co-authored-by: Pantheon Robot <[email protected]> Co-authored-by: Phil Tyler <[email protected]>
AnaisPantheor
added a commit
that referenced
this pull request
Jan 9, 2026
…connector users (#445) * update readme and changelog * refactor scenarios * Add more early returns --------- Co-authored-by: Pantheon Robot <[email protected]> Co-authored-by: Phil Tyler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New branch based on all the latest additions to develop (previously #423 with massive merge conflicts)
SimpleSAMLphp security warnings were displayed to users using the OneLogin/internal connector, even though these warnings are only relevant to SimpleSAMLphp users.
This PR adds stricter connection type checks to SimpleSAMLphp version warnings to prevent them from displaying to users who are not actually using SimpleSAMLphp authentication.
Behat tests are expected to fail until #447 is merged into develop, all tests on #447 are passing now.
SimpleSAMLphp version and connection type validation
Scenario 1: User is using OneLogin/internal connector with explicit config
Scenario 2: User is trying to use SimpleSAMLphp
Scenario 3: User is actively using SimpleSAMLphp
Scenario 4: Ambiguous - we don't know if library is detected, but config says SimpleSAMLphp
TO DO:
Help users distinguish between cases a) and b) with better messaging.