[BUGS-7135]: Updates code to resolve auth issue. #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is always going to point to the parent theme, so it's better for the stylesheet name to be something generic rather than something outdated
because this prepare script differs from most of our other behat-prepare scripts, let's be more explicit about the steps so we know what it's doing when we look back at this in six+ months
jazzsequence
approved these changes
Nov 22, 2023
Merged
msalle
pushed a commit
to msalle/wp-saml-auth
that referenced
this pull request
Jun 18, 2025
…_2.1.4 * Add pantheon-wp-coding-standards (pantheon-systems#339) * add our coding standard * run phpcbf * updates the ruleset name to be less generic * add rule exclusions in specific files * bump the php test version * remove excluded squiz rule we're handling that inside Pantheon-WP * manual rule exclusions * use wp_kses to sanitize output * validate & sanitize PHP superclobal * set lint php version to 8.0 * Bump symfony/filesystem from 5.4.21 to 5.4.23 (pantheon-systems#341) Bumps [symfony/filesystem](https://github.com/symfony/filesystem) from 5.4.21 to 5.4.23. - [Release notes](https://github.com/symfony/filesystem/releases) - [Changelog](https://github.com/symfony/filesystem/blob/6.2/CHANGELOG.md) - [Commits](symfony/filesystem@v5.4.21...v5.4.23) --- updated-dependencies: - dependency-name: symfony/filesystem dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update CONTRIBUTING.md * fixup changelog and prepare 2.1.4-dev * Bump yoast/phpunit-polyfills from 1.0.5 to 2.0.0 (pantheon-systems#343) * Bump yoast/phpunit-polyfills from 1.0.5 to 2.0.0 Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 1.0.5 to 2.0.0. - [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases) - [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/2.x/CHANGELOG.md) - [Commits](Yoast/PHPUnit-Polyfills@1.0.5...2.0.0) --- updated-dependencies: - dependency-name: yoast/phpunit-polyfills dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Phil Tyler <[email protected]> * Bump symfony/filesystem from 5.4.23 to 5.4.25 Bumps [symfony/filesystem](https://github.com/symfony/filesystem) from 5.4.23 to 5.4.25. - [Release notes](https://github.com/symfony/filesystem/releases) - [Changelog](https://github.com/symfony/filesystem/blob/6.3/CHANGELOG.md) - [Commits](symfony/filesystem@v5.4.23...v5.4.25) --- updated-dependencies: - dependency-name: symfony/filesystem dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * add the wporg-validator action (pantheon-systems#350) * add the wporg-validator action * updates changelog * Fix Readme.md spacing and add linting to ensure it remains (pantheon-systems#355) * Fix typo in the label for the certificate path (pantheon-systems#352) * [CMSP-519] Tested up to WordPress 6.3 (pantheon-systems#354) * Update changelog and CONTRIBUTING (pantheon-systems#356) * [CMSP-668] Update to latest Pantheon WP Coding Standard (pantheon-systems#357) * use latest pantheon wp coding standards * linting fixes * bump lockfile * update changelog * fix readme * [BUGS-7135]: Updates code to resolve auth issue. (pantheon-systems#359) * [BUGS-7135]: Updates code to resolve auth issue. * if wp login not permitted, force saml auth * run phpcbf for easy lint fixes * bump dependencies * don't activate a non-existant theme * change the parent theme * restore the theme to activate back to the custom one * rename the theme styles this is always going to point to the parent theme, so it's better for the stylesheet name to be something generic rather than something outdated * update element that contains the page title * be more verbose in our logging because this prepare script differs from most of our other behat-prepare scripts, let's be more explicit about the steps so we know what it's doing when we look back at this in six+ months * fix CAPSLOCK * use the lint-test GHA to run linting * remove the : --------- Co-authored-by: Ryan Wagner <[email protected]> Co-authored-by: Chris Reynolds <[email protected]> * [CMSP-480] mVDP Readme Update (pantheon-systems#349) * adds Patchstack info to readme(s) * update changelog * bump version to 2.1.4 * update changelog --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Phil Tyler <[email protected]> Co-authored-by: J Ryan Wagner <[email protected]> Co-authored-by: mscherer <[email protected]> Co-authored-by: Ryan Wagner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the auth issue that was reported. It also updates the Behat tests so that they're passing using the latest pantheon-wordpress-upstream-tests (which involved updating the child theme created in the
behat-preparescript). I've also added more verbose logging duringbehat-prepareso we have a better idea of what's going on since thisbehat-preparediffers from most of our other repositories.