Make sure the plugin can be translated using translate.wordpress.org#230
Merged
danielbachhuber merged 2 commits intopantheon-systems:masterfrom Feb 3, 2021
imath:fix/load-textdomain
Merged
Make sure the plugin can be translated using translate.wordpress.org#230danielbachhuber merged 2 commits intopantheon-systems:masterfrom imath:fix/load-textdomain
danielbachhuber merged 2 commits intopantheon-systems:masterfrom
imath:fix/load-textdomain
Conversation
Contributor
|
Thanks @imath! I'll tag v1.1.1 in a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks a lot for your work on this very useful plugin. I wanted to contribute to the fr_FR translation from https://translate.wordpress.org/projects/wp-plugins/wp-saml-auth/ unfortunately it looks like the plugin needs to use the
load_plugin_textdomain()function to make this possible (I've checked the log into the slack channel described below).So I'm suggesting to do so into this PR and as I've found there was already some po/mo files for the french locale, I've updated them to latest version of the plugin.