update fallback CACHE_PORT and CACHE_PASSWORD values#428
Closed
jazzsequence wants to merge 4 commits intodefaultfrom
Closed
update fallback CACHE_PORT and CACHE_PASSWORD values#428jazzsequence wants to merge 4 commits intodefaultfrom
jazzsequence wants to merge 4 commits intodefaultfrom
Conversation
This was referenced Jun 5, 2023
Contributor
|
@jazzsequence I've already made this fixes in my PR related to the issue #359 that I opened. |
Contributor
Author
|
@timnolte Circle can't run the automated tests on PRs from outside contributors so I've moved your changes over here. |
Contributor
Author
|
Fixed in #360 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
object-cache.phpCACHE_PORTandCACHE_PASSWORDfallback values that were changes in the mix for #400.Uses the values that were originally proposed in #360 by @timnolte
fixes #359
closes #360