Skip to content

[BUGS-6127] Add support for flush_runtime and flush_group #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jspellman814 merged 13 commits into from
May 8, 2023
Merged

[BUGS-6127] Add support for flush_runtime and flush_group #405

jspellman814 merged 13 commits into from
May 8, 2023

Conversation

@jspellman814
Copy link

@jspellman814 jspellman814 commented May 1, 2023

Addresses #399.

@jspellman814 jspellman814 requested review from a team as code owners May 1, 2023 20:39
@jspellman814 jspellman814 marked this pull request as draft May 1, 2023 21:05
@jspellman814 jspellman814 marked this pull request as ready for review May 3, 2023 14:13
@pwtyler
Copy link
Member

pwtyler commented May 4, 2023

@jspellman814 this closes #366 as well, correct?

This was linked to issues May 5, 2023
As of WordPress 6.1 A Notice About Incorrect Support for wp_cache_flush_runtime #399
Closed
Implement wp_cache_flush_group #366
Closed
pwtyler
pwtyler reviewed May 5, 2023
View reviewed changes
Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests included.

@jspellman814 jspellman814 requested a review from pwtyler May 5, 2023 22:39
pwtyler
pwtyler approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jspellman814, I bumped the minor version number per the new policy in CONTRIBUTING.md, please make sure I caught all instances and you're onboard with the change.

Makes me think perhaps we should use the same in the changelog headings as well (instead of ### Latest ###), but that's a conversation for elsewhere.

@jspellman814 jspellman814 requested review from a team and pwtyler May 8, 2023 14:03
@jspellman814 jspellman814 merged commit 009f716 into develop May 8, 2023
@jspellman814 jspellman814 deleted the bugs-6127 branch May 8, 2023 19:41
jspellman814 pushed a commit that referenced this pull request May 8, 2023
[BUGS-6127] Add support for flush_runtime and flush_group (#405)
eed3696
jspellman814 pushed a commit that referenced this pull request May 9, 2023
[BUGS-6127] Add support for flush_runtime and flush_group (#405)
2b2a1b5
@spacedmonkey spacedmonkey mentioned this pull request May 10, 2023
Closed
@pwtyler pwtyler mentioned this pull request May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pwtyler pwtyler pwtyler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

As of WordPress 6.1 A Notice About Incorrect Support for wp_cache_flush_runtime Implement wp_cache_flush_group

3 participants

@jspellman814 @pwtyler