Support Relay via WP_REDIS_USE_RELAY#344
Merged
danielbachhuber merged 2 commits intopantheon-systems:masterfrom Feb 18, 2022
Merged
Support Relay via WP_REDIS_USE_RELAY#344danielbachhuber merged 2 commits intopantheon-systems:masterfrom
WP_REDIS_USE_RELAY#344danielbachhuber merged 2 commits intopantheon-systems:masterfrom
Conversation
Contributor
|
@tillkruss Got the go-ahead from the internal team, with one request:
You can include it in *Installation, after the mention of Human Made's adaptor: https://github.com/pantheon-systems/wp-redis#installation |
also link Redis hash expiration issue
Contributor
Author
|
@danielbachhuber Thanks for following up. I've added the requested notes in ddee391. |
danielbachhuber
approved these changes
Feb 18, 2022
Contributor
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
👍 Thanks @tillkruss !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for Relay via
WP_REDIS_USE_RELAYconstant.I used a constant instead of
wp_redis_prepare_client_connection_callback, since it's a drop-in replacement for PhpRedis with an identical API.