Skip to content

Tweak initialization of the $wp_object_cache global#231

Merged
danielbachhuber merged 3 commits intopantheon-systems:masterfrom
partounian:patch-1
Dec 14, 2018
Merged

Tweak initialization of the $wp_object_cache global#231
danielbachhuber merged 3 commits intopantheon-systems:masterfrom
partounian:patch-1

Conversation

@partounian
Copy link
Copy Markdown
Contributor

@partounian partounian commented Dec 12, 2018

No description provided.

@danielbachhuber
Copy link
Copy Markdown
Contributor

danielbachhuber commented Dec 12, 2018

How does this fix the issue?

@partounian
Copy link
Copy Markdown
Contributor Author

partounian commented Dec 12, 2018

The original report stated

It looks like the global $wp_object_cache isn't set, aka its null when LudicrousDB tries to get something from the cache.

And then I copied these lines https://github.com/tillkruss/redis-cache/blob/68781b5b4cbd35c7eb2ca22d2d0db66ae57044fc/includes/object-cache.php#L180 as everything else seemed fine, and now it works for me.

Sorry for shoddy explanation, it just works for me :o

@danielbachhuber danielbachhuber added this to the 0.7.1 milestone Dec 13, 2018
@danielbachhuber danielbachhuber changed the title Fix issue #230 Tweak initialization of the $wp_object_cache global Dec 13, 2018
@danielbachhuber danielbachhuber self-assigned this Dec 13, 2018
@danielbachhuber
Copy link
Copy Markdown
Contributor

danielbachhuber commented Dec 13, 2018

The test failure against WP_VERSION=nightly seems to be because the nightly build ZIP hasn't caught up to the SVN checkout. I'll ship this tomorrow after I get a passing build.

@danielbachhuber danielbachhuber merged commit 778adb9 into pantheon-systems:master Dec 14, 2018
@partounian partounian deleted the patch-1 branch December 14, 2018 15:08
@danielbachhuber
Copy link
Copy Markdown
Contributor

danielbachhuber commented Dec 14, 2018

Just tagged the v0.7.1 release. Thanks again!

@kingkool68
Copy link
Copy Markdown

kingkool68 commented Dec 19, 2018

Woo thanks for the fix @partounian

Related stuttter/ludicrousdb#62

@partounian
Copy link
Copy Markdown
Contributor Author

partounian commented Dec 19, 2018

@kingkool68 thanks for the great issue description, I probably wouldn't have gotten it without you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@danielbachhuber danielbachhuber

Labels

None yet

Projects

None yet

Milestone

0.7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@partounian @danielbachhuber @kingkool68