Enhance informational Error message for the case of headers already sent #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code update enhances the error message displayed by the plugin when it is unable to perform its intended functionality due to headers already being sent. The original error message was "_session_set_save_handler(): Session save handler cannot be changed after headers have already been sent_" has been transformed into a more user-friendly and informative message. The updated error message helps users understand that the plugin was unable to work properly and provides insight into the cause, such as PHP throwing errors, the case that happened for me. By improving the error message, users can better troubleshoot and resolve the issue instead of thinking that wp-native-php-sessions plugin falied.
jazzsequence
previously approved these changes
May 30, 2023
Contributor
jazzsequence
left a comment
jazzsequence
left a comment
There was a problem hiding this comment.
LGTM. Made a couple minor fixes to spacing and added the textdomain to the __().
jazzsequence
approved these changes
May 30, 2023
Contributor
|
Next time, please make sure to branch from |
jspellman814
pushed a commit
that referenced
this pull request
Jun 1, 2023
jazzsequence
pushed a commit
that referenced
this pull request
Jun 1, 2023
* update contrib.md and version number * use correct pr number * fix lint error introduced in #249
pwtyler
pushed a commit
that referenced
this pull request
Jun 1, 2023
…ent (#249) * Enhance informational Error message for the case of headers already sent This code update enhances the error message displayed by the plugin when it is unable to perform its intended functionality due to headers already being sent. The original error message was "_session_set_save_handler(): Session save handler cannot be changed after headers have already been sent_" has been transformed into a more user-friendly and informative message. The updated error message helps users understand that the plugin was unable to work properly and provides insight into the cause, such as PHP throwing errors, the case that happened for me. By improving the error message, users can better troubleshoot and resolve the issue instead of thinking that wp-native-php-sessions plugin falied. * Add textdomain & fix spacing * fix spacing --------- Co-authored-by: Chris Reynolds <[email protected]>
pwtyler
pushed a commit
that referenced
this pull request
Jun 1, 2023
* update contrib.md and version number * use correct pr number * fix lint error introduced in #249
Merged
pwtyler
pushed a commit
that referenced
this pull request
Jun 1, 2023
…ent (#249) * Enhance informational Error message for the case of headers already sent This code update enhances the error message displayed by the plugin when it is unable to perform its intended functionality due to headers already being sent. The original error message was "_session_set_save_handler(): Session save handler cannot be changed after headers have already been sent_" has been transformed into a more user-friendly and informative message. The updated error message helps users understand that the plugin was unable to work properly and provides insight into the cause, such as PHP throwing errors, the case that happened for me. By improving the error message, users can better troubleshoot and resolve the issue instead of thinking that wp-native-php-sessions plugin falied. * Add textdomain & fix spacing * fix spacing --------- Co-authored-by: Chris Reynolds <[email protected]>
pwtyler
pushed a commit
that referenced
this pull request
Jun 1, 2023
* update contrib.md and version number * use correct pr number * fix lint error introduced in #249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code update enhances the error message displayed by the plugin when it is unable to perform its intended functionality due to headers already being sent.
The default original error message was:
"session_set_save_handler(): Session save handler cannot be changed after headers have already been sent"
and it has been transformed into a more user-friendly and informative message.
The updated error message helps users understand that the plugin was unable to work properly and provides insight into the cause, such as PHP throwing errors, the case that happened for me.
By improving the error message, users can better troubleshoot and resolve the issue instead of thinking that wp-native-php-sessions plugin falied.