Document session lifetime handling #224
Conversation
CdrMarks
left a comment
CdrMarks
left a comment
There was a problem hiding this comment.
Let me know what you think about the suggestions I made.
|
Please make this PR against develop as per CONTRIBUTING.md |
jspellman814
left a comment
jspellman814
left a comment
There was a problem hiding this comment.
This text should also be added to readme.txt so it appears on WP.org.
There is automation in place to handle this (though that goes from readme.txt to README.md and you've updated the .md file), or you can copy over manually
CdrMarks
dismissed
their stale review
John's right about the readme.txt file.
jms-pantheon
force-pushed
the
patch-1
branch
2 times, most recently
from
62930a6 to
6564099
Compare
|
Thanks for that review @jspellman814 I have set this PR to be based on Develop and made the change to readme.txt It seems like Markdown is only partially supported on WordPress.org for readme.txt files, I didn't find any examples of code blocks. Would it be better to include this as just straight text block, or as code with each line with its single back-ticks? |
|
@jms-pantheon We have some code samples in the solr-power readme.txt. Here's the rendering on wp.org: https://wordpress.org/plugins/solr-power/ |
|
Wow thank you, I searched really hard for that one @jspellman814 but couldn't find an example. I've changed this to use the same 4 space indent. |
jspellman814
left a comment
jspellman814
left a comment
There was a problem hiding this comment.
LGTM! Thanks @jms-pantheon 👍
* Ignore .wordpress-org directory (#223) * Make dependabot target develop branch (#226) * Document session lifetime handling (#224) * Release 1.3.1 Co-authored-by: jms-pantheon <[email protected]>
3 participants
No description provided.