Enhance get_client_ip_server() #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbachhuber
suggested changes
Aug 14, 2019
Contributor
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
Thanks for the follow-up PR, @dsturm. Can you fix the failing build, and add an assertion in the existing test case for this new scenario?
Contributor
Author
|
Hey @danielbachhuber, I fixed the error and added an assertion. After adding filter_var to validate against the value from $_SERVER, should there be the preg_replace() on return? |
Contributor
|
@dsturm Oops, missed your question before I landed this. The Also worth noting: I changed the prefix on the filter from |
Contributor
Author
|
Thanks for the info @danielbachhuber |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @todeveni mentioned (#124), the
X-Forwarded-ForHTTP Header could / should be in a comma seperated format. This PR adds support to get the first value of such list.It also adds a parameter for the
pantheon_client_ipfilter, which contains the HTTP Header key.Further the fetched IP value will be validated per
filter_var().