Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pantheon-systems/Pantheon-WP-Coding-Standards
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.0.3
Choose a base ref
...
head repository: pantheon-systems/Pantheon-WP-Coding-Standards
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.0.1
Choose a head ref
  • 13 commits
  • 13 files changed
  • 6 contributors

Commits on Aug 28, 2024

  1. Configuration menu
    Copy the full SHA
    ac3a546 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Configuration menu
    Copy the full SHA
    ef961fd View commit details
    Browse the repository at this point in the history
  2. Merge pull request #9 from pantheon-systems/add-catalog-info-20240910

    [SITE-1547] Add catalog-info.yml
    namespacebrian authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    863ef24 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    f9ade58 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #10 from pantheon-systems/rename-catalog-info-2024…

    …0923
    
    Rename catalog-info.yml to catalog-info.yaml
    namespacebrian authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c27064b View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2024

  1. Add @pantheon-systems/devrel to codeowners for coding standards (#13)

    * Add @pantheon-systems/devrel to coding standards codeowners
    
    * Update CODEOWNERS
    
    Co-authored-by: Phil Tyler <[email protected]>
    
    ---------
    
    Co-authored-by: Phil Tyler <[email protected]>
    jazzsequence and pwtyler authored Dec 10, 2024
    Configuration menu
    Copy the full SHA
    9588a0a View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2025

  1. add a dependabot.yml for composer updates (#14)

    this way we're informed of dependency updates
    jazzsequence authored Jul 17, 2025
    Configuration menu
    Copy the full SHA
    a9a69fc View commit details
    Browse the repository at this point in the history
  2. Ignore PHP errors related to the version being run (#12)

    This is an issue that is likely coming from PHPCompatibility or PHPCompatibility-WP. The issue was present in WPCS (but fixed in 3.0). There is no real benefit for leaving error reporting in when it has to do with a CS ruleset, so I think we can safely just ignore errors.
    See: WordPress/WordPress-Coding-Standards#2035
    See also: https://gist.github.com/shreyasikhar/f4495ac952586096eb81d505e9e914a4
    jazzsequence authored Jul 17, 2025
    Configuration menu
    Copy the full SHA
    25f3717 View commit details
    Browse the repository at this point in the history
  3. Update fig-r/psr2r-sniffer requirement from ^1.5 to ^2.2 (#17)

    Updates the requirements on [fig-r/psr2r-sniffer](https://github.com/php-fig-rectified/psr2r-sniffer) to permit the latest version.
    - [Release notes](https://github.com/php-fig-rectified/psr2r-sniffer/releases)
    - [Commits](php-fig-rectified/psr2r-sniffer@1.5.0...2.2.1)
    
    ---
    updated-dependencies:
    - dependency-name: fig-r/psr2r-sniffer
      dependency-version: 2.2.1
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jul 17, 2025
    Configuration menu
    Copy the full SHA
    1c92bce View commit details
    Browse the repository at this point in the history
  4. Update yoast/phpunit-polyfills requirement from 1.x-dev to 4.0.0 (#16)

    Updates the requirements on [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) to permit the latest version.
    - [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases)
    - [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/4.x/CHANGELOG.md)
    - [Commits](Yoast/PHPUnit-Polyfills@1.0.0...4.0.0)
    
    ---
    updated-dependencies:
    - dependency-name: yoast/phpunit-polyfills
      dependency-version: 4.0.0
      dependency-type: direct:development
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jul 17, 2025
    Configuration menu
    Copy the full SHA
    570e638 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2025

  1. Add DisallowRenameFunctionSniff for rename() restrictions (#18)

    * Add DisallowRenameFunctionSniff to enforce restrictions on rename() usage
    
    * remove phpcs stuff
    
    * exclude the wp rename sniff
    wp warns, we error
    
    * add a file to test the sniff against
    
    * add a script to run tests
    
    * add a composer test to test tests
    
    * test tests on push
    
    * exclude deprecated sniff from standards
    
    * fix spacing
    
    * add emoji
    
    * properly ignore deprecated sniff
    
    * add a comment for why we're excluding
    jazzsequence authored Jul 18, 2025
    Configuration menu
    Copy the full SHA
    40c96b5 View commit details
    Browse the repository at this point in the history
  2. Add Pantheon-WP coding standards for comment usage (#19)

    * autoload both classes
    
    * Group pantheon rules together
    
    * exclude the multiline slash comment rule
    we're redeclaring in Pantheon-WP with a higher severity
    
    * duplicate exclusions in -Minimum
    We need to redeclare because we're redeclaring the parent rulesets
    
    * exclude deprecated VIP CSS/JS checks
    
    * add our Pantheon-WP checks
    
    * add DisallowMultilineSlashCommentSniff to enforce single-line comment usage
    
    * feat(sniffs): add sniff to disallow multiline slash comments
    
    Introduces the new `DisallowMultilineSlashCommentSniff` to improve comment consistency and readability.
    
    This sniff performs two main checks:
    - It flags consecutive single-line `//` comments, enforcing the use of `/* ... */` block syntax for multiline comments.
    - It issues a warning for any comment line that exceeds 80 characters to encourage better formatting.
    
    * add test cases for sniffs
    
    * add helper scripts
    so we can test things manually easier
    
    * break the reusable single line comment code into a static method
    
    * use the static method to call the single line comment sniff
    
    * update the tess to support passing a ruleset to test
    
    * add line breaks between tests for readability
    
    * change echo to printf for portability
    
    * use file headers to determine test name
    
    * just echo an empty line
    
    * maybe a space?
    
    * add an error param
    so the severity level can be adjusted
    
    * pass an error for Pantheon-WP
    
    * include severity in the tests
    jazzsequence authored Jul 18, 2025
    Configuration menu
    Copy the full SHA
    79ee409 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2025

  1. Improve comment handling (#20)

    * add new test case
    
    * don't flag inline comments
    jazzsequence authored Jul 21, 2025
    Configuration menu
    Copy the full SHA
    40a97fc View commit details
    Browse the repository at this point in the history
Loading