You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit ed42596
Browse filesBrowse the repository at this point in the historyBrowse files
fix(overlay): take page answers only from the page's owner
The result handlers for router, form, NgRx, component pick and signal
peek requests settled a pending request for any connection that sent
its requestId. Requests are broadcast to every client, so another tab
or a stray client could answer for the page an agent asked. Keep the
target pageId with each pending request and settle it only when the
answer names that page and comes from the connection that owns it.
The security page described every write without page as refused while
more than one page could take it. Only dispatch-ngrx-action does that.
Say so, and that navigate and other tools pick a page.
The readOnly commit on this branch says readOnly kept highlight. It did
not: highlight was an action tool and readOnly dropped it. This branch
makes highlight a read tool, so readOnly now keeps it, and drops
record-pipes and the record argument of change-detection.
Refs #340
Copy file name to clipboardExpand all lines: apps/docs/src/content/security.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -160,7 +160,7 @@ If you build the extension with another `key`, add its origin to `allowedOrigins
160
160
161
161
### Page ownership
162
162
163
-
Each tab, Angular Native app or Capacitor app that reports to the server has a page id. The first connection that reports a page owns it. A report or a `forget` for that page id from any other connection is ignored, so one client can't overwrite or remove the data of another tab.
163
+
Each tab, Angular Native app or Capacitor app that reports to the server has a page id. The first connection that reports a page owns it. A report or a `forget` for that page id from any other connection is ignored, so one client can't overwrite or remove the data of another tab. The answer to a request sent to a page, such as a navigation, a form action, an NgRx dispatch or a component pick, is taken only from the connection that owns that page.
164
164
165
165
A page reconnects with the same page id after a reload. To take its page back, the overlay mints a random secret together with the page id and sends it before its first report. In a browser, the overlay keeps both in `sessionStorage` for the life of the tab. A duplicated tab gets a fresh pair. Angular Native and NativeScript apps keep both in memory. Another connection takes over a page id in one of these cases:
166
166
@@ -170,7 +170,7 @@ A page reconnects with the same page id after a reload. To take its page back, t
170
170
| The old connection closed | On its next report. |
171
171
| The old connection sent nothing for 15 s | On its next report. A tab in the background stays owned while it says it is still there. |
172
172
173
-
Agent tools and the panel don't report pages, so these rules don't apply to them. A write that leaves out `page`, such as [`dispatch-ngrx-action`](./agents/tools.md#dispatch-an-action), is refused while more than one page could take it. The answer lists those pages, so you can call it again with one.
173
+
Agent tools and the panel don't report pages, so these rules don't apply to them. [`dispatch-ngrx-action`](./agents/tools.md#dispatch-an-action) without `page`is refused while more than one page reports NgRx state. The answer lists those pages, so you can call it again with one. Other tools that act on a page pick one when `page` is left out. `navigate`, for example, acts on the first page that reports a router. Pass `page` when more than one tab is open.
0 commit comments