Skip to content

TYP: enable reportUnknownMemberType - #1639

Merged
Dr-Irv merged 7 commits into
pandas-dev:mainfrom
cmp0xff:feature/enable-report-unknown-member-type
Jan 20, 2026
Merged

Dr-Irv merged 7 commits into
pandas-dev:mainfrom
cmp0xff:feature/enable-report-unknown-member-type

Conversation

@cmp0xff

@cmp0xff cmp0xff commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

We can also optionally remove pyright_strict.

Comment thread pyproject.toml Resolved
@cmp0xff

cmp0xff commented Jan 20, 2026

Copy link
Copy Markdown
Contributor Author

/pyright_strict

Comment thread tests/frame/test_frame.py Resolved
Comment thread tests/frame/test_indexing.py Outdated
@@ -1,4 +1,4 @@
# pyright: reportUnknownLambdaType=false
# pyright: reportUnknownLambdaType=false,reportUnknownMemberType=false

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as in test_frame

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread tests/series/test_series.py Resolved
Comment thread tests/test_plotting.py Resolved
Comment thread pyproject.toml Resolved
Comment thread pyrightconfig-strict.json Resolved
@cmp0xff
cmp0xff requested a review from Dr-Irv January 20, 2026 17:30

@Dr-Irv Dr-Irv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if strict now always works, can we now just change the type checking in CI to always use strict and remove the strict from nightly ?

@cmp0xff
cmp0xff requested a review from Dr-Irv January 20, 2026 21:08

@Dr-Irv Dr-Irv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @cmp0xff . Nice work to get strict working over multiple PRs!

@Dr-Irv
Dr-Irv merged commit 7686bcf into pandas-dev:main Jan 20, 2026
16 checks passed
@cmp0xff
cmp0xff deleted the feature/enable-report-unknown-member-type branch January 21, 2026 17:08
cmp0xff added a commit to cmp0xff/pandas-stubs that referenced this pull request Aug 28, 2026
* TYP: enable `reportUnknownMemberType`

* simplify import

* remove reportUnknownLambdaType and useLibraryCodeForTypes

* add comment

* more accurate ignores

* matplotlib/matplotlib#31003

* pyright is pyright_strict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strict report as of 3/13/2025

2 participants