Skip to content

BUG: frame.loc[2:, 'z'] not setting inplace when multi-block #44345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 5 commits into from
Nov 13, 2021
Merged

BUG: frame.loc[2:, 'z'] not setting inplace when multi-block #44345

jreback merged 5 commits into from
Nov 13, 2021

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Nov 7, 2021

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

jreback
jreback reviewed Nov 11, 2021
View reviewed changes
pandas/tests/frame/indexing/test_setitem.py
# TODO(ArrayManager) .loc still overwrites
expected["B"] = expected["B"].astype("int64")

mark = pytest.mark.xfail(
Copy link
Contributor

@jreback jreback Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what this about?

Copy link
Member Author

@jbrockmendel jbrockmendel Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ArrayManager behavior is different for reasons i'm still chasing down

@jreback jreback added the Indexing Related to indexing on series/frames, not to indexes themselves label Nov 11, 2021
@jreback
Copy link
Contributor

jreback commented Nov 11, 2021

is this user facing at all?

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Nov 11, 2021

is this user facing at all?

yes, will update with whatsnew

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Nov 11, 2021

whatsnew added + green

@jreback jreback added this to the 1.4 milestone Nov 11, 2021
@jreback
Copy link
Contributor

jreback commented Nov 11, 2021

cc @phofl if you can have a look

phofl
phofl approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback merged commit 573c063 into pandas-dev:master Nov 13, 2021
@jbrockmendel jbrockmendel deleted the api-bug-inplace branch November 13, 2021 00:32
nickleus27 pushed a commit to nickleus27/pandas that referenced this pull request Nov 28, 2021
@jbrockmendel @nickleus27
BUG: frame.loc[2:, 'z'] not setting inplace when multi-block (pandas-…
0010c6d 
…dev#44345)
@simonjayhawkins simonjayhawkins mentioned this pull request Jul 28, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreback jreback jreback left review comments

@phofl phofl phofl approved these changes

Assignees

No one assigned

Labels

Indexing Related to indexing on series/frames, not to indexes themselves

Projects

None yet

Milestone

1.4

Development

Successfully merging this pull request may close these issues.

3 participants

@jbrockmendel @jreback @phofl