Fixed file path in Make_Binary function.#31
Merged
panagiks merged 1 commit intopanagiks:masterfrom Oct 25, 2016
Merged
Conversation
Owner
|
Hmm. Looks like you found (and fixed) an error I hadn't seen (but was there the whole time). The error mentioned in #26 (as it came up in a hackathon two days ago) was when giving a totally non-existent filename (i.e. messing up the name when typing it), but none of us tried to make a file located on a sub-dir (locally) and so we never caught this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, now it works fine,
of course remote execution need execution permissions to be set on the remote file,
and this still has to be done manually.