Skip to content

Fixed file path in Make_Binary function.#31

Merged
panagiks merged 1 commit intopanagiks:masterfrom
n1zzo:master
Oct 25, 2016
Merged

Fixed file path in Make_Binary function.#31
panagiks merged 1 commit intopanagiks:masterfrom
n1zzo:master

Conversation

@n1zzo
Copy link
Copy Markdown
Contributor

@n1zzo n1zzo commented Oct 25, 2016

Okay, now it works fine,
of course remote execution need execution permissions to be set on the remote file,
and this still has to be done manually.

@panagiks
Copy link
Copy Markdown
Owner

panagiks commented Oct 25, 2016

Hmm. Looks like you found (and fixed) an error I hadn't seen (but was there the whole time). The error mentioned in #26 (as it came up in a hackathon two days ago) was when giving a totally non-existent filename (i.e. messing up the name when typing it), but none of us tried to make a file located on a sub-dir (locally) and so we never caught this.
So some extra thank you for fixing something that would have had me scratching my head when it came up :)
(As for the cause of #26 it's the fact that despite using the with open() syntax we get the file's length before and cast it to an int, found it a few moments ago and will patch asap).
Thank you again for your contribution and I hope to see you around again soon.
Cheers!

@panagiks panagiks merged commit 16bd83c into panagiks:master Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants