Accept AsyncIterables being passed to Response#341
Closed
mjsir911 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
I want to add tests for this somehow |
mjsir911
force-pushed
the
fix_response_typing
branch
3 times, most recently
from
May 20, 2024 14:43
a6bf4ae to
c9323e1
Compare
mjsir911
marked this pull request as ready for review
May 20, 2024 14:43
Contributor
Author
|
@davidism ready for review, would like extra eyes on the test specifically |
Contributor
Author
I've been told I don't need to do this and it will be gotten to later. |
mjsir911
force-pushed
the
fix_response_typing
branch
from
May 20, 2024 18:41
c9323e1 to
3df3018
Compare
Contributor
Author
|
It would be cool if |
mjsir911
force-pushed
the
fix_response_typing
branch
4 times, most recently
from
May 21, 2024 01:57
bea08c1 to
88f728b
Compare
|
Is there anything stopping this from being merged? |
pgjones
approved these changes
Nov 14, 2024
Member
|
Merged manually in a80358b to fix conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pallets/flask#5322
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.