Skip to content

Add style for sphinx-tabs extension#31

Merged
davidism merged 1 commit intopallets:masterfrom
greyli:add-sphinx-tabs-style
Apr 13, 2021
Merged

Add style for sphinx-tabs extension#31
davidism merged 1 commit intopallets:masterfrom
greyli:add-sphinx-tabs-style

Conversation

@greyli
Copy link
Copy Markdown
Contributor

@greyli greyli commented Aug 2, 2020

Add style for the new Sphinx extension (sphinx-tabs) introduced in Flask documentation (pallets/flask#3714). This is the original style:

image-20200802130954306

The is the improved style (it may still need to improve):

image-20200802131211668

@return42
Copy link
Copy Markdown

return42 commented Jan 2, 2021

I would vote against this PR (sorry).

I use pallets in several projects and I like to stay with the defaults from sphinx-tab. This PR replaces the defaults from sphinx-tab what should not be an object of the pallets project, I think.

@davidism davidism merged commit 869ccf5 into pallets:master Apr 13, 2021
@greyli greyli deleted the add-sphinx-tabs-style branch May 12, 2021 03:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants