Enable stack cookies for C speedups #74
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Sep 19, 2017
Member
ThiefMaster
left a comment
ThiefMaster
left a comment
There was a problem hiding this comment.
does this work on windows too?
Member
|
Re: working on Windows, that appveyor failure doesn't mean anything, since it's not configured correctly right now, for some reason the appveyor for my fork picks up prs on the origin repo. :-/ So, we still need to know if this works on Windows. |
Merged
Member
|
I'll rebase this in a bit, should trigger a new Windows build. |
Contributor
|
@olivierbufalini Why did you propose this?
|
Author
Member
|
Closing, please address the discussion in #73 first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.