Skip to content

Restore Python 3.2 compatibility. - #13

Closed
tseaver wants to merge 1 commit into
pallets:masterfrom
tseaver:restore_py32_compat
Closed

tseaver wants to merge 1 commit into
pallets:masterfrom
tseaver:restore_py32_compat

Conversation

@tseaver

@tseaver tseaver commented May 22, 2013

Copy link
Copy Markdown

No description provided.

@gewthen

gewthen commented May 22, 2013

Copy link
Copy Markdown

Yes. This would be a good thing. Pyramid uses Markupsafe and errors when I try to install it:

Running MarkupSafe-0.18/setup.py -q bdist_egg --dist-dir /tmp/easy_install-9q77mm/MarkupSafe-0.18/egg-dist-tmp-pm_q77
File "build/bdist.linux-x86_64/egg/markupsafe/init.py", line 68
def new(cls, base=u'', encoding=None, errors='strict'):
^
SyntaxError: invalid syntax

File "build/bdist.linux-x86_64/egg/markupsafe/tests.py", line 51
), Markup(u'<foo>:<bar>'))
^
SyntaxError: invalid syntax

File "/home/XXXX/..../env/lib/python3.2/site-packages/MarkupSafe-0.18-py3.2-linux-x86_64.egg/markupsafe/init.py", line 68
def new(cls, base=u'', encoding=None, errors='strict'):
^
SyntaxError: invalid syntax

File "/home/XXXX/....env/lib/python3.2/site-packages/MarkupSafe-0.18-py3.2-linux-x86_64.egg/markupsafe/tests.py", line 51
), Markup(u'<foo>:<bar>'))
^
SyntaxError: invalid syntax

Adding MarkupSafe 0.18 to easy-install.pth file

@domenkozar

Copy link
Copy Markdown

+1

@g2p

g2p commented May 24, 2013

Copy link
Copy Markdown

Mako also pulls MarkupSafe. Please apply.

@zzzeek

zzzeek commented May 24, 2013

Copy link
Copy Markdown

I've released mako 0.8.1 that just skips markupsafe in setup.py for the various versions. by the time we finish arguing with armin everyone will be on 3.3.

@tseaver

tseaver commented May 24, 2013

Copy link
Copy Markdown
Author

Thanks, @zzzeek!

@lei12

lei12 commented Jun 7, 2013

Copy link
Copy Markdown

+1

@gordio

gordio commented Jul 18, 2013

Copy link
Copy Markdown

I don't understand. Project restore Python 3 compatibility, or no?

  Running setup.py install for markupsafe

    building 'markupsafe._speedups' extension
    x86_64-pc-linux-gnu-gcc -pthread -fPIC -I/usr/include/python3.2 -c markupsafe/_speedups.c -o build/temp.linux-x86_64-3.2/markupsafe/_speedups.o
    x86_64-pc-linux-gnu-gcc -pthread -shared build/temp.linux-x86_64-3.2/markupsafe/_speedups.o -L/usr/lib64 -lpython3.2 -o build/lib.linux-x86_64-3.2/markupsafe/_speedups.cpython-32.so
      File "/home/gordio/Documents/gwp-flask/.env/lib64/python3.2/site-packages/markupsafe/tests.py", line 51
        ), Markup(u'<em>&lt;foo&gt;:&lt;bar&gt;</em>'))
                                                    ^
    SyntaxError: invalid syntax

      File "/home/gordio/Documents/gwp-flask/.env/lib64/python3.2/site-packages/markupsafe/__init__.py", line 68
        def __new__(cls, base=u'', encoding=None, errors='strict'):
                                ^
    SyntaxError: invalid syntax

@tseaver

tseaver commented Jul 18, 2013

Copy link
Copy Markdown
Author

@gordio: As far as I know, @mitsuhiko hasn't merged my fixes, which means that markupsafe is only compatible with Python 3.3 (not 3.2).

@mitsuhiko

Copy link
Copy Markdown
Contributor

I currently have no plans to restore 3.2 support. None of my other libraries support 3.2 any more and for many of those the changes in 3.3 are necessary to make the codebase sane. You can already depend on an older version if you want to use 3.2 anyways so I don't see a huge reason to do this change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants