Skip to content

Fix url_prefix argument for nesting blueprint#4036

Merged
davidism merged 1 commit intopallets:2.0.xfrom
greyli:fix-nesting-bp
May 13, 2021
Merged

Fix url_prefix argument for nesting blueprint#4036
davidism merged 1 commit intopallets:2.0.xfrom
greyli:fix-nesting-bp

Conversation

@greyli
Copy link
Copy Markdown
Contributor

@greyli greyli commented May 13, 2021

fixes #4037

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@greyli greyli added this to the 2.0.1 milestone May 13, 2021
@greyli greyli marked this pull request as ready for review May 13, 2021 10:43
@greyli greyli requested a review from pgjones May 13, 2021 11:10
@pgjones pgjones self-requested a review May 13, 2021 19:48
@davidism
Copy link
Copy Markdown
Member

davidism commented May 13, 2021

@pgjones I noticed while working on this that we're registering blueprints differently in blueprints vs apps. I would expect Blueprint.register_blueprint to immediately register all the child's stuff, just like Flask.register_blueprint works. I think we should look into refactoring that later.

@davidism davidism merged commit f3551c8 into pallets:2.0.x May 13, 2021
@greyli greyli deleted the fix-nesting-bp branch May 14, 2021 00:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants