Set default encoding to UTF-8 for load_dotenv#3932
Merged
davidism merged 1 commit intopallets:masterfrom Mar 10, 2021
Merged
Conversation
Contributor
Author
|
@davidism Is it needed to update the changelog and the cli docs for this change? (I was just about to push the commit...) |
Member
|
@greyli oops, sorry about that, I didn't think they were particularly necessary here, but if you've already got it we might as well add it in. |
Contributor
Author
|
No worries, I also think it's not quite necessary, just tried to fill the checkboxs :p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will set encoding to UTF-8 when calling
dotenv.load_dotenv().fixes #3931
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.