fix: add support for TypeScript 4.0#4943
Conversation
|
Thanks for your interest in palantir/tslint, @alan-agius4! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
f3cd994 to
727286e
Compare
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Thanks for sending this in @alan-agius4! The changes under src/ look good to me. Just hoping we can work around the major version change for tslib.
JoshuaKGoldberg
added
PR: waiting for author
PR: waiting for reviewer
and removed
PR: waiting for author
labels
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Tentatively 👍 from me, assuming nobody else has anything to say.
adidahiya
left a comment
adidahiya
left a comment
There was a problem hiding this comment.
do not upgrade to tslib 2.0
e6baa9d to
e45174d
Compare
adidahiya
left a comment
adidahiya
left a comment
There was a problem hiding this comment.
sorry for not mentioning this earlier -- pinning to a beta version feels a little more stable than dev
| "tslint-plugin-prettier": "^2.0.1", | ||
| "tslint-test-config-non-relative": "file:test/external/tslint-test-config-non-relative", | ||
| "typescript": "~3.8.2", | ||
| "typescript": "~4.0.0-dev.20200722", |
4 participants
Closes #4941