This repository was archived by the owner on Mar 25, 2021. It is now read-only.
fix: writeFileSync can not write to temp files on macOS 10.15#4887
Merged
Conversation
Member
|
Thanks for your interest in palantir/tslint, @i1skn! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
JoshuaKGoldberg
approved these changes
Nov 6, 2019
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the surgical fix you two!
FYI @adidahiya
Contributor
|
Build failures in |
i1skn
added a commit
to celo-org/celo-monorepo
that referenced
this pull request
Nov 20, 2019
i1skn
added a commit
to celo-org/celo-monorepo
that referenced
this pull request
Nov 26, 2019
This was referenced Mar 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
[ ] Documentation updateOverview of change:
Add
path.resolvewhenfs.writeFileSynccalled with temp file path.Credits for the idea hot to fix the issue goes to @dhleong #4880 (comment)
Is there anything you'd like reviewers to focus on?
Actually tests were failing on macOS Catalina before this fix.