This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Bugfix/number literal format fix#4856
Merged
JoshuaKGoldberg merged 2 commits intoSep 12, 2019
Merged
Conversation
Member
|
Thanks for your interest in palantir/tslint, @rgant! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
JoshuaKGoldberg
approved these changes
Sep 12, 2019
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
Contributor
There was a problem hiding this comment.
Love it, thanks @rgant!
JoshuaKGoldberg
added
the
PR: waiting for CLA
Contributor
Author
|
I signed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
The fixer for number-literal-format did not preserve significant zeros in the number. Changed the RegEx so it would better match decimals with leading and internal zeros as they are significant. Still trims trailing (insignificant) zeros.
Is there anything you'd like reviewers to focus on?
For some reason I had to add two blank lines to the end of
test/rules/number-literal-format/test.ts.fixI cannot see why that happened.CHANGELOG.md entry:
[bugfix] Preserve significant zeros in fixer for number-literal-format