Skip to content
This repository was archived by the owner on Mar 25, 2021. It is now read-only.

Upgrade diff to 4.0.1#4852

Merged
adidahiya merged 2 commits into
palantir:masterfrom
akshayas:asrivatsa_upgrade_diff
Sep 9, 2019
Merged

Upgrade diff to 4.0.1#4852
adidahiya merged 2 commits into
palantir:masterfrom
akshayas:asrivatsa_upgrade_diff

Conversation

@akshayas

@akshayas akshayas commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

PR checklist

  • Addresses an existing issue: fixes #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

Github/dependabot reported a high severity bug with jsdiff. The exact wording is

WS-2018-0590 More information
high severity
Vulnerable versions: < 3.5.0
Patched version: 3.5.0
A vulnerability was found in diff before v3.5.0, the affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) attacks.

This diff bumps up the version to the latest available jsdiff 4.0.1.

Is there anything you'd like reviewers to focus on?

No

CHANGELOG.md entry:

N/A

@palantirtech

palantirtech commented Sep 9, 2019

Copy link
Copy Markdown
Member

Thanks for your interest in palantir/tslint, @akshayas! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@adidahiya

adidahiya commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

thanks @akshayas

@adidahiya
adidahiya merged commit 7659cd9 into palantir:master Sep 9, 2019
@akshayas
akshayas deleted the asrivatsa_upgrade_diff branch September 10, 2019 00:01
@adidahiya adidahiya mentioned this pull request Sep 10, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 11, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
This was referenced Nov 13, 2019
Merged
Merged
Open
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 19, 2020
Merged
This was referenced Mar 18, 2020
Closed
Open
Open
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 31, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 12, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 22, 2020
Open
@dependabot dependabot Bot mentioned this pull request Mar 15, 2021
Closed
@christian-thiel-webcom christian-thiel-webcom mentioned this pull request Aug 10, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@adidahiya adidahiya adidahiya approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akshayas @palantirtech @adidahiya