This repository was archived by the owner on Mar 25, 2021. It is now read-only.
4746: fix weird failures in strict-boolean-expressions for 'ignore-rhs' option#4833
Merged
JoshuaKGoldberg merged 2 commits intoAug 25, 2019
Conversation
JoshuaKGoldberg
approved these changes
Aug 25, 2019
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the fix @tanmoyopenroot!
Contributor
|
Failures in testNext and testRc are unrelated. |
This was referenced Nov 13, 2019
This was referenced Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
check expression only if
leftnode is not aBooleanBinaryExpressionCHANGELOG.md entry:
[bugfix] fix
strict-boolean-expressionsfalse positive with"ignore-rhs"option