preserve spark properties on async subquery tasks #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
reviewed
Jun 13, 2019
| } | ||
| } | ||
|
|
||
| test("SPARK-27744: Subquery execution preserves spark local properties") { |
There was a problem hiding this comment.
Only question - does this fail without your change?
|
👍 lgtm |
|
hey @yifeih should we revert and get more feedback or is this okay? |
|
The code looks fine to me, but I think @onursatici or @robert3005 will have more context on whether this is a risky or urgent change |
Author
|
It is not risky, but not that urgent as well, good to have in the next release though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream SPARK-XXXXX ticket and PR link (if not applicable, explain)
https://issues.apache.org/jira/browse/SPARK-27744
apache#24625
What changes were proposed in this pull request?
preserve spark properties on subquery exec tasks
How was this patch tested?
unit tests