Fix crash when formatting method references #1630
Merged
bulldozer-bot[bot] merged 1 commit intodevelopfrom Mar 26, 2026
Merged
Conversation
Generate changelog in
|
✅ Successfully generated changelog entry!Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 📋Changelog Preview🐛 Fixes
|
| something = 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 | ||
| + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 | ||
| + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2 + 2; | ||
| return StreamEx.of(itemsToCreate) |
Contributor
Author
There was a problem hiding this comment.
this in the input, the output is in A.output, previously it was failing at this line. The tests are making sure that formatting A.input will result in A.output
There was a problem hiding this comment.
this is A.output no? I suppose I didn't understand the diff because it didn't look like there was anything different? But you're basically saying the equivalent of: assertThatCode(...).doesNotThrow()?
felixdesouza
approved these changes
Mar 26, 2026
|
Released 2.90.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
Internal thread here
Formatting code containing a method reference whose qualifier is a simple method call (e.g.
getModificationContext()::getRestrictionStatusOrDefault) threw:This happened because
CountWidthUntilBreakVisitor.visitLevel— which computes how wide a prefix is before its first break — assumed all levels either had a special inlineability hint or started with nested Level objects. A simple method call starts with aToken, which matched neither case and fell through to a throw.After this PR
The fallback instead walks the level's docs, summing their widths until the first Break.
==COMMIT_MSG==
Fix crash when formatting method references
==COMMIT_MSG==
Possible downsides?