Skip to content

add secretbox_easy and secretbox_open_easy - #45

Merged
paixaop merged 3 commits into
paixaop:masterfrom
dominictarr:secretbox_easy
Jul 30, 2015
Merged

add secretbox_easy and secretbox_open_easy#45
paixaop merged 3 commits into
paixaop:masterfrom
dominictarr:secretbox_easy

Conversation

@dominictarr

Copy link
Copy Markdown
Contributor

fixes #44

dominictarr added a commit to dominictarr/pull-box-stream that referenced this pull request Jun 17, 2015
@paixaop

paixaop commented Jun 18, 2015

Copy link
Copy Markdown
Owner

@dominictarr can you write the tests for the new functions? I will merge them in.

@dominictarr

Copy link
Copy Markdown
Contributor Author

Okay I added tests. Rather than just copy-paste the old tests i rewrote them so that less code was required.

@dominictarr

Copy link
Copy Markdown
Contributor Author

oops, just realized I left a change out. This passes now.

@dominictarr

Copy link
Copy Markdown
Contributor Author

hey is this okay is there anything you would like me to change about this?

paixaop added a commit that referenced this pull request Jul 30, 2015
add secretbox_easy and secretbox_open_easy
@paixaop
paixaop merged commit 8f1d8b3 into paixaop:master Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

should bind to secretbox_easy not secretbox

2 participants