constrain and bump typescript versions #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
Author
|
@PabloLION @kamiazya Got a rough idea of if/when this can be looked at? |
kamiazya
approved these changes
Jun 1, 2023
Collaborator
kamiazya
left a comment
kamiazya
left a comment
There was a problem hiding this comment.
Sorry for the slow response, I've been busy.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest publicly released version of
madgehas a runtime dependency oftypescript@^3.9.5. #350 moved it topeerDependenciesand lifted the version range to*.This PR proposes to constrain the
typescriptversions supported inpeerDependenciesto either of:^3.9.5(backwards-compat withmadge@6.0.0)^5(supporting current version makes sense if it already works)^4.9.5(only makes sense considering the above but don't support legacy4.x)The intention here is to reduce the range of supported versions to make it more feasible to test for, as well as the risk of future regressions or unplanned breaking changes.