Remove mz as a production dependency. Instead use pify for promisifying. #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mz sticks around as a dev dependency
Owner
|
What's the reason for this change? |
Contributor
Author
|
Sorry, should've explained that in the first post. |
Owner
|
Ok, I see :) Why keep mz as a dev dependency and not use pify there too? |
Contributor
Author
|
That's not as easy as a test uses the The test using Lines 263 to 264 in 7fce4b7 |
Owner
|
Ok, I see. Then I have no problem with merging this :) |
nmeylan
pushed a commit
to nmeylan/madge
that referenced
this pull request
Jan 7, 2020
Remove mz as a production dependency. Instead use pify for promisifying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mz sticks around as a dev dependency