Skip to content

chore: [IOBP-1914] IDPay email banner mixpanel tap events#7346

Merged
LeleDallas merged 3 commits into
masterfrom
IOBP-1914
Sep 15, 2025
Merged

chore: [IOBP-1914] IDPay email banner mixpanel tap events#7346
LeleDallas merged 3 commits into
masterfrom
IOBP-1914

Conversation

@LeleDallas

Copy link
Copy Markdown
Contributor

Short description

This pull request adds user interaction tracking to the EmailNotificationBanner component to improve analytics on banner usage

List of changes proposed in this pull request

  • Introduced a new mixPanelTracking function to track "TAP_BANNER" and "CLOSE_BANNER" events with relevant banner and page information

How to test

Ensure that all properties are tracked correctly

@LeleDallas LeleDallas self-assigned this Sep 12, 2025
@LeleDallas LeleDallas added the Legacy-IO-Bonus e pagamenti Legacy label used during the development of `IO - Bonus e pagamenti` stream label Sep 12, 2025
@github-actions

Copy link
Copy Markdown
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@github-actions

github-actions Bot commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

Jira Pull Request Link

This Pull Request refers to Jira issues:

@codecov

codecov Bot commented Sep 12, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.24%. Comparing base (d20ff3a) to head (db4d3e7).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...rvices/home/components/EmailNotificationBanner.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7346       +/-   ##
===========================================
+ Coverage   45.96%   59.24%   +13.27%     
===========================================
  Files        1771     1793       +22     
  Lines       37922    38292      +370     
  Branches     8616     8664       +48     
===========================================
+ Hits        17432    22686     +5254     
+ Misses      20422    15535     -4887     
- Partials       68       71        +3     
Files with missing lines Coverage Δ
...rvices/home/components/EmailNotificationBanner.tsx 3.22% <0.00%> (-0.48%) ⬇️

... and 427 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d20ff3a...db4d3e7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hantex9 Hantex9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IDPay Legacy-IO-Bonus e pagamenti Legacy label used during the development of `IO - Bonus e pagamenti` stream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants