fix: Fix toolbar flickering when scrolling lists#26
Merged
nikclayton merged 1 commit intopachli:developfrom Sep 11, 2023
Merged
fix: Fix toolbar flickering when scrolling lists#26nikclayton merged 1 commit intopachli:developfrom
nikclayton merged 1 commit intopachli:developfrom
Conversation
Scrolling a thread, set of search results, or viewing a thread would cause the toolbar to flicker as items moved under it. Fix this by configuring the toolbar to `liftOnScroll` in the relevant layouts. It needs to be configured with the view (or ID of the view) that it will be scrolling. For views that are in the same layout this is done with the `liftOnScrollTargetViewId` attribute. For views that are in different layouts (e.g. the toolbar is in the activity and the scrolling view is in a fragment) the app bar's `setLiftOnScrollTargetView` method must be called. Do this in `TimelineFragment` if the hosting activity is a new interface `AppBarLayoutHost`. Implement this interface in `StatusListActivity`. Update the relevant layouts to use `MaterialToolbar`. Fixes pachli#21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrolling a thread, set of search results, or viewing a thread would cause the toolbar to flicker as items moved under it.
Fix this by configuring the toolbar to
liftOnScrollin the relevant layouts.It needs to be configured with the view (or ID of the view) that it will be scrolling. For views that are in the same layout this is done with the
liftOnScrollTargetViewIdattribute.For views that are in different layouts (e.g. the toolbar is in the activity and the scrolling view is in a fragment) the app bar's
setLiftOnScrollTargetViewmethod must be called.Do this in
TimelineFragmentif the hosting activity is a new interfaceAppBarLayoutHost. Implement this interface inStatusListActivity.Update the relevant layouts to use
MaterialToolbar.Fixes #21