fix: Update tab contents when moved#2181
Merged
nikclayton merged 1 commit intopachli:mainfrom Mar 23, 2026
Merged
Conversation
The previous code was using the default implementation of `getItemId` and `containsItem` in the adapter for tabs. These are based on the tab's position and don't work correctly if tabs can move in the adapter fragments are created. The symptom is the viewpager shows a tab in its old position after moving. Fix this by basing the item ID on each fragment's hashcode(). Fixes pachli#2178
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code was using the default implementation of
getItemIdandcontainsItemin the adapter for tabs. These are based on the tab's position and don't work correctly if tabs can move in the adapter after fragments are created.The symptom is the viewpager shows a tab in its old position after moving.
Fix this by basing the item ID on each fragment's hashcode().
Fixes #2178