fix: Ensure database migrations work when upgrading from very old versions#2129
Merged
nikclayton merged 1 commit intopachli:mainfrom Feb 20, 2026
Merged
fix: Ensure database migrations work when upgrading from very old versions#2129nikclayton merged 1 commit intopachli:mainfrom
nikclayton merged 1 commit intopachli:mainfrom
Conversation
…sions Switching to bundled SQLite means that if the user is upgrading from a prior version that has a database migration the migration has to be re-written to use the bundled SQLite (migrations are run with whatever database driver is active now, not whatever database driver was used when the migration was written). So all the `onPostMigrate` and `migrate` functions have to take `SQLiteConnection` as a parameter and be re-written to use that where necessary. If this isn't done then (a) all the `onPostMigrate` functions are skipped, and (b) any `migrate` functions will throw an exception. Fixes pachli#2119, pachli#2062
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching to bundled SQLite means that if the user is upgrading from a prior version that has a database migration the migration has to be re-written to use the bundled SQLite (migrations are run with whatever database driver is active now, not whatever database driver was used when the migration was written).
So all the
onPostMigrateandmigratefunctions have to takeSQLiteConnectionas a parameter and be re-written to use that where necessary.If this isn't done then (a) all the
onPostMigratefunctions are skipped, and (b) anymigratefunctions will throw an exception.Fixes #2119, #2062