fix: Show animated avatars in preview card bylines#2019
Merged
nikclayton merged 2 commits intopachli:mainfrom Dec 8, 2025
Merged
fix: Show animated avatars in preview card bylines#2019nikclayton merged 2 commits intopachli:mainfrom
nikclayton merged 2 commits intopachli:mainfrom
Conversation
nikclayton
force-pushed
the
anim-preview
branch
from
083ced1 to
ae9c01f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
If the avatar in a preview card byline was animated the animation wasn't being started, so the avatar didn't appear. Fix that. Write two new `CustomTarget` implementations that can load bitmaps and drawables into a `TextView` drawable, and select between them based on whether animation is enabled and the avatar is being loaded as a bitmap or a drawable.
nikclayton
force-pushed
the
anim-preview
branch
from
ae9c01f to
5184add
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the avatar in a preview card byline was animated the animation wasn't being started, so the avatar didn't appear.
Fix that. Write two new
CustomTargetimplementations that can load bitmaps and drawables into aTextViewdrawable, and select between them based on whether animation is enabled and the avatar is being loaded as a bitmap or a drawable.