fix(deps): update okhttp to 5.3.2, okio to 3.16.4#2016
Merged
nikclayton merged 1 commit intopachli:mainfrom Dec 6, 2025
Merged
fix(deps): update okhttp to 5.3.2, okio to 3.16.4#2016nikclayton merged 1 commit intopachli:mainfrom
nikclayton merged 1 commit intopachli:mainfrom
Conversation
nikclayton
added a commit
to nikclayton/pachli-android
that referenced
this pull request
Feb 5, 2026
Previous code was triggering media playback when the transition from the preview image on the previous activity to the preview image in the fragment hosted by `ViewMediaActivity` had completed. This never completes if there was no preview image. For example, some audio files, or if the user has disabled media previews. This also meant the UI controls never appeared. Fix this by triggering playback on `onEnterAnimationComplete`, which completes after the enter animation (including shared element transitions) have completed. Fixes pachli#2016
nikclayton
added a commit
that referenced
this pull request
Feb 5, 2026
Previous code was triggering media playback when the transition from the preview image on the previous activity to the preview image in the fragment hosted by `ViewMediaActivity` had completed. This never completes if there was no preview image. For example, some audio files, or if the user has disabled media previews. This also meant the UI controls never appeared. Fix this by triggering playback on `onEnterAnimationComplete`, which completes after the enter animation (including shared element transitions) have completed. Fixes #2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.