fix: Prevent OOM, actually prune the database#2012
Merged
nikclayton merged 1 commit intopachli:mainfrom Dec 5, 2025
Merged
Conversation
`onPostMigrate(db: SupportSQLiteDatabase)` **is not called** if Room is configured with a driver (see https://developer.android.com/reference/androidx/room/migration/AutoMigrationSpec#onPostMigrate(androidx.sqlite.db.SupportSQLiteDatabase)). So the previous code wasn't running, the database wasn't being pruned, and users were seeing OOM crashes. Fix this by overriding the version that takes `SQLiteConnection`. This requires a new database version because users may already have installed a version with the no-op migration.
nikclayton
changed the title
nikclayton
added a commit
to nikclayton/pachli-android
that referenced
this pull request
Dec 5, 2025
`onPostMigrate(db: SupportSQLiteDatabase)` **is not called** if Room is configured with a driver (see https://developer.android.com/reference/androidx/room/migration/AutoMigrationSpec#onPostMigrate(androidx.sqlite.db.SupportSQLiteDatabase)). So the previous code wasn't running, the database wasn't being pruned, and users were seeing OOM crashes. Fix this by overriding the version that takes `SQLiteConnection`. This requires a new database version because users may already have installed a version with the no-op migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onPostMigrate(db: SupportSQLiteDatabase)is not called if Room is configured with a driver (see https://developer.android.com/reference/androidx/room/migration/AutoMigrationSpec#onPostMigrate(androidx.sqlite.db.SupportSQLiteDatabase)).So the previous code wasn't running, the database wasn't being pruned, and users were seeing OOM crashes.
Fix this by overriding the version that takes
SQLiteConnection. This requires a new database version because users may already have installed a version with the no-op migration.