fix: Don't crash when prompting for notification provider#1987
Merged
nikclayton merged 1 commit intopachli:mainfrom Dec 1, 2025
Merged
fix: Don't crash when prompting for notification provider#1987nikclayton merged 1 commit intopachli:mainfrom
nikclayton merged 1 commit intopachli:mainfrom
Conversation
Dialogs must be shown on the main (UI) thread. Enforce this in the suspend dialog extensions by explicitly switching to `Dispatchers.Main`. Fixes a crash; EnableAllNotificationsUseCase runs on `Dispatchers.IO` (because it interacts with `SharedPreferences` which can perform IO) and can show a dialog. The dialog was being displayed on an IO thread and crashed with: Can't create handler inside thread Thread[DefaultDispatcher-worker-9,5,main] that has not called Looper.prepare() Fixes pachli#1986
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dialogs must be shown on the main (UI) thread. Enforce this in the suspend dialog extensions by explicitly switching to
Dispatchers.Main.Fixes a crash; EnableAllNotificationsUseCase runs on
Dispatchers.IO(because it interacts withSharedPreferenceswhich can perform IO) and can show a dialog. The dialog was being displayed on an IO thread and crashed with:Fixes #1986