fix: Improve display of error causes on timelines#1924
Merged
nikclayton merged 1 commit intopachli:mainfrom Nov 15, 2025
Merged
fix: Improve display of error causes on timelines#1924nikclayton merged 1 commit intopachli:mainfrom
nikclayton merged 1 commit intopachli:mainfrom
Conversation
Previous code had a number of issues: 1. JSON decoding errors processing pages in *RemoteMediator created empty pages instead of reporting the error up the stack. 2. JSON decoding errors from Room converters didn't include enough information to determine the source of the problem. 3. Processing `CombinedLoadStates` could miss error states in `source.refresh` because of how `CombinedLoadStates` merges the states. Fix all of these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code had a number of issues:
JSON decoding errors processing pages in *RemoteMediator created empty pages instead of reporting the error up the stack.
JSON decoding errors from Room converters didn't include enough information to determine the source of the problem.
Processing
CombinedLoadStatescould miss error states insource.refreshbecause of howCombinedLoadStatesmerges the states.Fix all of these.