fix: Allow for filters to be cleared on non-cached timelines#1887
Merged
nikclayton merged 1 commit intopachli:mainfrom Oct 27, 2025
Merged
fix: Allow for filters to be cleared on non-cached timelines#1887nikclayton merged 1 commit intopachli:mainfrom
nikclayton merged 1 commit intopachli:mainfrom
Conversation
When updating statuses based on user actions on non-cached timelines the previous code was both (a) acting on the wrong status ID (should have used the real ID, not the actionable ID), and (b) not calling the provided `updater` function if the status was a reblog. The net effect was that if a non-cached timeline, like a list, contained a status that was both 1. a reblog, and 2. filtered, the "Clear filters" button was displayed, but didn't do anything. Fixes pachli#1875
nikclayton
force-pushed
the
1875-show-anyway
branch
from
f75baa1 to
2d529ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating statuses based on user actions on non-cached timelines the previous code was both (a) acting on the wrong status ID (should have used the real ID, not the actionable ID), and (b) not calling the provided
updaterfunction if the status was a reblog.The net effect was that if a non-cached timeline, like a list, contained a status that was both 1. a reblog, and 2. filtered, the "Clear filters" button was displayed, but didn't do anything.
Fixes #1875