enhance the grammar of invalid_replacement_field#66
Merged
pablogsal merged 2 commits intopablogsal:fstring-grammar-rebased-after-sprintfrom Apr 9, 2023
Conversation
Author
|
The column number is crucial especially in nested fstring-replacement-fields. e.g. File "<stdin>", line 1
f"{123:{234 +}}"
^
SyntaxError: f-string: expecting '}'now File "<stdin>", line 1
f"{123:{234 +}}"
^
SyntaxError: f-string: expecting '=', or '!', or ':', or '}'The variable names in C was spontaneously picked though. But I do carefully changed all occurence of Request for comment. |
Author
|
I think we can even make one step further with c9de3e8 for more consistency, while this changes many errors messages. This will capture many File "<string>", line 1
f'{}'
^
SyntaxError: f-string: expecting expression after '{'
AssertionError: "f-string: empty expression not allowed" does not match "f-string: expecting expression after '{' (<string>, line 1)"
File "<string>", line 1
f'{!r}'
^
SyntaxError: f-string: expecting expression after '{'
AssertionError: "f-string: expression required before '!'" does not match "f-string: expecting expression after '{' (<string>, line 1)"
File "<string>", line 2
:a}'''
^
SyntaxError: f-string: expecting expression after '{'
AssertionError: "f-string: expression required before ':'" does not match "f-string: expecting expression after '{' (<string>, line 2)"
File "<string>", line 1
f'{,}'
^
SyntaxError: f-string: expecting expression after '{'
AssertionError: "invalid syntax" does not match "f-string: expecting expression after '{' (<string>, line 1)"
File "<string>", line 1
f'{4:{/5}}'
^
SyntaxError: f-string: expecting expression after '{'
AssertionError: "f-string: invalid syntax" does not match "f-string: expecting expression after '{' (<string>, line 1)" |
Owner
|
Whops, I have merged the wrong PR. @sunmy2019 Can you reopen this so we can discuss it more? I am going to revert it on the pep branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am struggling with finding the correct SyntaxError location. I add a new tool
RAISE_SYNTAX_ERROR_ON_NEXT_TOKENfor this use case.While it increases the test failure of
test_fstring, I think this change is beneficial.Notable changes:
before
now (nicer hint)
before
now (points to the right token)
before:
now (points to the correct token, nicer hint):
before
now (nicer hint)