Skip to content

Reduce popup text overlapping using MessagesMap#635

Merged
ozkriff merged 4 commits into
masterfrom
i214_reduce_text_overlapping
Sep 23, 2020
Merged

Reduce popup text overlapping using MessagesMap#635
ozkriff merged 4 commits into
masterfrom
i214_reduce_text_overlapping

Conversation

@ozkriff

@ozkriff ozkriff commented Sep 22, 2020

Copy link
Copy Markdown
Owner

It's not perfect but seems good enough to reduce the most common popup text collisions.

This PR:

  • Adds MessagesMap to store text lifetimes during the event visualization.
  • Adds enum CommandOrigin { Player, Internal }.
  • Tweaks lot's of timings.
  • Removes a lot of action::Sleep from visualizer.rs.
  • Replaces some vec![] with plain [].
  • Removes "Vanish" message.

Closes #214 ("Reduce text overlapping")

@ozkriff ozkriff force-pushed the i214_reduce_text_overlapping branch from 19d27d5 to ce12036 Compare September 22, 2020 21:04
@ozkriff ozkriff merged commit 4f6180b into master Sep 23, 2020
@ozkriff ozkriff deleted the i214_reduce_text_overlapping branch September 23, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce text overlapping

1 participant