Skip to content

Properly clear & unsubscribe from report updates#85

Merged
nvuillam merged 1 commit intomainfrom
82-old-report-receiving-updates-from-ongoing-analysis
Aug 14, 2023
Merged

Properly clear & unsubscribe from report updates#85
nvuillam merged 1 commit intomainfrom
82-old-report-receiving-updates-from-ongoing-analysis

Conversation

@itayox
Copy link
Copy Markdown
Contributor

@itayox itayox commented Aug 14, 2023

When report page unmounts we now do the following:

  1. Unsubscribe from ongoing updates
  2. Clear report store state

Prior to this change, unsubscribe was being called at a later stage.

@itayox itayox added the bug Something isn't working label Aug 14, 2023
@itayox itayox linked an issue Aug 14, 2023 that may be closed by this pull request
@itayox itayox self-assigned this Aug 14, 2023
@github-actions
Copy link
Copy Markdown

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ ACTION actionlint 6 3 0.05s
✅ COPYPASTE jscpd yes no 4.4s
⚠️ CSS stylelint 3 0 1 1.33s
✅ DOCKERFILE hadolint 1 0 0.07s
✅ HTML djlint 1 0 0.75s
✅ HTML htmlhint 1 0 0.26s
✅ JSON eslint-plugin-jsonc 19 0 0 2.38s
✅ JSON jsonlint 19 0 0.22s
✅ JSON npm-package-json-lint yes no 0.55s
✅ JSON prettier 19 0 0 2.01s
✅ JSON v8r 19 0 20.41s
⚠️ MARKDOWN markdownlint 10 0 31 1.69s
✅ MARKDOWN markdown-table-formatter 10 0 0 0.48s
✅ REPOSITORY checkov yes no 26.25s
✅ REPOSITORY gitleaks yes no 2.68s
✅ REPOSITORY git_diff yes no 0.13s
✅ REPOSITORY grype yes no 10.72s
⚠️ REPOSITORY kics yes 1 21.13s
✅ REPOSITORY secretlint yes no 2.24s
✅ REPOSITORY trivy yes no 4.79s
✅ REPOSITORY trivy-sbom yes no 1.16s
✅ REPOSITORY trufflehog yes no 3.66s
✅ SPELL cspell 56 0 4.18s
✅ SPELL lychee 43 0 6.13s
✅ YAML prettier 11 0 0 0.89s
✅ YAML v8r 11 0 17.16s
✅ YAML yamllint 11 0 0.51s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@itayox itayox requested a review from nvuillam August 14, 2023 19:58
@nvuillam nvuillam merged commit 09dde4f into main Aug 14, 2023
@nvuillam nvuillam deleted the 82-old-report-receiving-updates-from-ongoing-analysis branch August 14, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Completed report receiving updates from ongoing analysis

2 participants