Skip to content

63 SBOM parser requests data over http synchronously#66

Merged
nvuillam merged 4 commits intomainfrom
63-sbom-parser-requests-data-over-http-synchronously
Aug 10, 2023
Merged

63 SBOM parser requests data over http synchronously#66
nvuillam merged 4 commits intomainfrom
63-sbom-parser-requests-data-over-http-synchronously

Conversation

@itayox
Copy link
Copy Markdown
Contributor

@itayox itayox commented Aug 10, 2023

This fixes the long wait for SBOM packages information to arrive.

  • Added a function fetchPackages to fetch all packages (async) before parsing packages information
  • Utility functions like getPackages, fetchNpm/Py.. were moved to sbom/sbom-utils.ts
  • Types specific for SBOM were moved to sbom/sbom-types.ts

@eyalatox Please review, I made some changes to your code. All seems to work fine 👍

@itayox itayox added the bug Something isn't working label Aug 10, 2023
@itayox itayox requested review from eyalatox and nvuillam August 10, 2023 14:19
@itayox itayox self-assigned this Aug 10, 2023
@itayox itayox linked an issue Aug 10, 2023 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 10, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ ACTION actionlint 6 3 0.04s
✅ COPYPASTE jscpd yes no 3.76s
⚠️ CSS stylelint 3 0 1 1.4s
✅ DOCKERFILE hadolint 1 0 0.06s
✅ HTML djlint 1 0 0.8s
✅ HTML htmlhint 1 0 0.27s
✅ JSON eslint-plugin-jsonc 19 0 0 2.41s
✅ JSON jsonlint 19 0 0.22s
✅ JSON npm-package-json-lint yes no 0.64s
✅ JSON prettier 19 0 0 1.66s
✅ JSON v8r 19 0 21.49s
⚠️ MARKDOWN markdownlint 10 0 31 1.58s
✅ MARKDOWN markdown-table-formatter 10 0 0 0.45s
✅ REPOSITORY checkov yes no 25.64s
✅ REPOSITORY gitleaks yes no 2.68s
✅ REPOSITORY git_diff yes no 0.14s
✅ REPOSITORY grype yes no 10.63s
⚠️ REPOSITORY kics yes 1 20.05s
✅ REPOSITORY secretlint yes no 2.1s
✅ REPOSITORY trivy yes no 5.45s
✅ REPOSITORY trivy-sbom yes no 1.11s
✅ REPOSITORY trufflehog yes no 3.92s
✅ SPELL cspell 56 0 5.02s
✅ SPELL lychee 43 0 2.88s
✅ YAML prettier 11 0 0 0.95s
✅ YAML v8r 11 0 17.02s
✅ YAML yamllint 11 0 0.49s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@nvuillam nvuillam merged commit b9c1930 into main Aug 10, 2023
@nvuillam nvuillam deleted the 63-sbom-parser-requests-data-over-http-synchronously branch August 10, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SBOM parser requests data over HTTP synchronously

2 participants