Skip to content

Remove some unused packages from the project#106

Merged
nvuillam merged 3 commits intomainfrom
105-remove-unused-packages-from-the-project
Aug 19, 2023
Merged

Remove some unused packages from the project#106
nvuillam merged 3 commits intomainfrom
105-remove-unused-packages-from-the-project

Conversation

@itayox
Copy link
Copy Markdown
Contributor

@itayox itayox commented Aug 17, 2023

Cleanup unused dependencies in package.json files

@itayox itayox linked an issue Aug 17, 2023 that may be closed by this pull request
@itayox itayox self-assigned this Aug 17, 2023
@itayox itayox added the infrastructure Dev experience, infra, testing label Aug 17, 2023
@itayox itayox requested a review from nvuillam August 17, 2023 18:29
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 17, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ ACTION actionlint 6 3 0.19s
✅ COPYPASTE jscpd yes no 3.9s
⚠️ CSS stylelint 3 0 1 1.4s
✅ DOCKERFILE hadolint 1 0 0.17s
✅ HTML djlint 1 0 1.28s
✅ HTML htmlhint 1 0 0.28s
✅ JSON eslint-plugin-jsonc 19 0 0 3.24s
✅ JSON jsonlint 19 0 0.23s
✅ JSON npm-package-json-lint yes no 0.81s
✅ JSON prettier 19 0 0 1.54s
✅ JSON v8r 19 0 20.9s
⚠️ MARKDOWN markdownlint 10 0 31 2.22s
✅ MARKDOWN markdown-table-formatter 10 0 0 0.5s
✅ REPOSITORY checkov yes no 27.14s
✅ REPOSITORY gitleaks yes no 3.43s
✅ REPOSITORY git_diff yes no 0.19s
✅ REPOSITORY grype yes no 10.31s
⚠️ REPOSITORY kics yes 1 22.62s
✅ REPOSITORY secretlint yes no 2.32s
✅ REPOSITORY trivy yes no 4.77s
✅ REPOSITORY trivy-sbom yes no 1.16s
✅ REPOSITORY trufflehog yes no 6.13s
✅ SPELL cspell 56 0 4.5s
✅ SPELL lychee 43 0 3.77s
✅ YAML prettier 11 0 0 0.92s
✅ YAML v8r 11 0 17.25s
✅ YAML yamllint 11 0 0.47s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@nvuillam
Copy link
Copy Markdown
Member

@itayox can I let you merge the conflicts for this one ? I'm kind of afraid to destroy package-lock.json ^^

@itayox
Copy link
Copy Markdown
Contributor Author

itayox commented Aug 18, 2023 via email

@nvuillam
Copy link
Copy Markdown
Member

@itayox sometimes there are updates specific to package-lock.json, like upgrades from dependabot or npm audit fix, that's why i didn't want to overwrite any of them ^^

@itayox
Copy link
Copy Markdown
Contributor Author

itayox commented Aug 18, 2023 via email

@itayox
Copy link
Copy Markdown
Contributor Author

itayox commented Aug 19, 2023

@nvuillam conflicts resolved 👍

@nvuillam nvuillam merged commit 2b9e5a3 into main Aug 19, 2023
@nvuillam nvuillam deleted the 105-remove-unused-packages-from-the-project branch August 19, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Dev experience, infra, testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused packages from the project

2 participants